文档: todo销账(batch29 ARC-05/06+FR-D3+R-PD-10)+待审查登记+DOC整理
- todo: ARC-05越层核验0命中+四领域拆分/ARC-06破环aiShared/FR-D3三子项闭环销账+新增ARC-06b遗留
- 待审查: 登记CR-260616-02(batch29+R-PD-10代码 fc767e1)待审
- DOC-14: df-storage/SQLite-CRUD文档表数V13/V9→V15对齐migrations.rs schema_version=15
This commit is contained in:
36
docs/待审查.md
36
docs/待审查.md
@@ -23,23 +23,39 @@
|
||||
|
||||
## 当前队列
|
||||
|
||||
### CR-260616-01-fixes 审查待修项修复批次 — 🟡 待审(低优先,主代理已核查)
|
||||
### CR-260616-02 batch29+R-PD-10 代码改动批次 — 🟡 待审
|
||||
|
||||
- **状态**: 🟡 待审(低优先 — 小修+主代理已独立核查双绿,独立审查 agent 可选核)
|
||||
- **来源**: CR-260616-01 审查待修项①类7项(cr01-fixes workflow `wu4r8ejcp`)
|
||||
- **commit**: `fc767e1` 优化: R-PD-10 storage_err DRY统一 + FR-D3 migrations if链转数组循环
|
||||
- **状态**: 🟡 待审(中优 — DRY 重构 + 迁移逻辑改,主代理已独立核查)
|
||||
- **改动文件**:
|
||||
- `src/views/TaskDetail.vue`(.status-testing/.status-blocked CSS + advancing 接文案)
|
||||
- `crates/df-storage/src/crud.rs`(CAS SQL 加 `AND deleted_at IS NULL` 两分支 + 白名单注释)
|
||||
- `crates/df-nodes/src/task_advance_node.rs`(ALL_STATES.join DRY + 测试改名)
|
||||
- `src-tauri/src/state.rs`(build_registry 补 TaskAdvanceNode 未注册注释)
|
||||
- **主代理核查**: cargo check --workspace exit 0(仅 pre-existing warning)+ vue-tsc exit 0 + git diff 边界合规(4 文件符合 agent 领地)
|
||||
- **审查关注点**:①CR-01-B CAS 补 deleted_at 语义正确性(回收站任务必败)②CR-01-A CSS 配色跨视图一致 ③CR-01-C DRY 无运行时文案变更
|
||||
- **未做**: CR-01-D(错误枚举区分)/CR-01-G(i18n 分级)②类留 todo
|
||||
- `crates/df-storage/src/crud.rs`(R-PD-10: 110 处 `.map_err(|e| Error::Storage(e.to_string()))` 统一 `storage_err` helper)
|
||||
- `crates/df-storage/src/migrations.rs`(FR-D3: run() 15 个 `if current_version<N` 块改 `[(i32, fn); 15]` step 数组循环,零行为变更)
|
||||
- **主代理核查**: cargo check -p df-storage exit 0 + cargo test -p df-storage 11 集成全过(含 open_in_memory→run 全量迁移路径)+ git diff 边界合规(2 文件符合 df-storage 域)
|
||||
- **审查关注点**: ①R-PD-10 helper 泛型 `E: ToString` 全 110 处类型兼容 ②FR-D3 step 数组循环行为等价(同 current_version 同序执行同 migrate_vN)③迁移数据安全(PRAGMA 幂等探测 + schema_version INSERT 保留)
|
||||
- **范围外**: ARC-05/06 验证性无代码改动(此前批次已闭环,本次仅核验)+ DOC 文档(V13→V15 表数对齐,低审)
|
||||
|
||||
---
|
||||
|
||||
## 已审归档
|
||||
|
||||
### CR-260616-01-fixes 审查待修项修复批次 — ✅ 已审(PASS)
|
||||
|
||||
- **commit**: `4dc5219` 修复: CR-01审查待修项①类7项(CSS补 testing/blocked 徽章 + CAS防回收站推进 + DRY + 注释 + 测试改名 + advancing 接文案)
|
||||
- **审查时间**: 2026-06-16(独立审查 agent · 防"主代理已核查双绿"代入,亲核源码)
|
||||
- **总体结论**: ✅ **PASS** — 🔴0 🟡0 ⚪2(范围外观察项)
|
||||
- **独立核验**(不信主代理核查声明,grep/read 亲验 7 项①类修复):
|
||||
- ① **CR-01-B CAS deleted_at 语义** ✅ — `soft_delete`(crud.rs:800)设 `deleted_at` 非空;`advance_status_atomic` 两分支(bump_rounds + 普通,crud.rs:855/859)均加 `AND deleted_at IS NULL`,回收站任务 `affected=0 → None` 必败。D-02 软删收口正确,一处关闭。
|
||||
- ② **CR-01-A CSS 配色跨视图一致** ✅ — TaskDetail.vue:344-345 与 Tasks.vue:413-414 **逐字镜像**(testing 橙 `#ff9800` / blocked 红danger 0.5px 边框),跨视图统一。
|
||||
- ③ **CR-01-C DRY 文案零变更** ✅ — `ALL_STATES`(task_state_machine.rs:48-56)= `["todo","in_progress","in_review","testing","done","blocked","cancelled"]`,`join("/")` = 原硬编码串,顺序与值全等,无运行时文案变化。
|
||||
- **CR-01-H 测试改名** ✅ — `cas_returns_none_when_status_mismatch`(task_advance_node.rs:313)真存在,改名后注释指向正确的 CAS 失败测试。
|
||||
- **CR-01-I advancing i18n** ✅ — zh/en 均有(taskDetail.ts:38 `推进中.../Advancing...`),TaskDetail.vue:63 接 advancing 态。
|
||||
- **CR-01-F 白名单注释** ✅ — `allowed_columns_for("tasks")`(crud.rs:331)数组无 `review_rounds` + 注释说明专用路径(仅 advance_status_atomic),收口防误补。
|
||||
- **CR-01-E state.rs 注释** ✅ — build_registry(state.rs:240)注释准确,说明 TaskAdvanceNode 未注册原因(阶段2 DAG 联动时加)。
|
||||
- **范围外(记录不审,非本批缺陷)**:
|
||||
- ⚪ **工作区 crud.rs 226行未提交** = `R-PD-10` `storage_err` DRY 重构(提取包装函数替换散落 `.map_err(|e| Error::Storage(e.to_string()))`),非 4dc5219 范围,独立审查留待其 commit。
|
||||
- ⚪ **`status-abandoned` CSS class ↔ `cancelled` 后端态** = 历史命名别名(`constants/project.ts:83` `cancelled: 'status-abandoned'` 映射闭环,功能正确),非本批引入。命名语义瑕疵(abandoned 弃用 ≠ cancelled 取消),low,可选优化。
|
||||
- **待修项回流 todo**: **无**(7 项全过,无新缺陷)。
|
||||
|
||||
### CR-260616-01 任务推进链(batch28) — ✅ 已审
|
||||
|
||||
- **commit**: `d2cb38c` 新增: 任务推进链(7态状态机+advance_task CAS原子写)+软删除+前后端7态对齐
|
||||
|
||||
Reference in New Issue
Block a user