重构: confirmDialog抽composable+tool_result反向查找+search列限定

- FR-D5 抽 useConfirm 收敛 4 视图(Projects/ProjectDetail/Ideas/Settings)确认弹层重复
- FR-D4 replace_tool_result_content 正向 O(n) 改反向 rposition(审批替换命中最近,调用低频)
- FR-D2 search_vector SELECT * 改显式 14 列(消除隐式依赖,字段级精简待单独立项)
This commit is contained in:
2026-06-14 22:50:59 +08:00
parent 36d68ddb26
commit 4a95f6a1e2
7 changed files with 84 additions and 62 deletions

View File

@@ -278,8 +278,11 @@ impl ContextManager {
/// 就地替换某条 tool_result 的内容(兼容审批 replace_tool_result
/// 返回 true 如果找到并替换了
///
/// 反向遍历tool_result 由 append 进入历史,被替换的通常是最近的审批占位,
/// 从尾部查找命中即停,避免对长历史做正向 O(n) 累积扫描。
pub fn replace_tool_result_content(&mut self, tool_call_id: &str, new_content: &str) -> bool {
let pos = self.messages.iter().position(|t| {
let pos = self.messages.iter().rposition(|t| {
matches!(t.message.role, MessageRole::Tool)
&& t.message.tool_call_id.as_deref() == Some(tool_call_id)
});

View File

@@ -1174,13 +1174,29 @@ impl KnowledgeRepo {
///
/// 返回 (记录, 相似度分数)。数据量 <50k 时暴力遍历 <50ms,够用;
/// 更大规模再升 sqlite-vec HNSW(结果不变,只提速)。
///
/// 列限定: 显式列出所需列(与 search/list_by_status/top_used 一致),避免 SELECT *
/// 拉到未知新增列;embedding 单独取(不入 KnowledgeRecord)。
///
/// TODO(性能,低优先): 调用方(hybrid_search→merge_hybrid_results→build_knowledge_context)
/// 实际只消费 id/kind/title/content/reuse_count;reasoning(AI 生成大文本)、tags、
/// source_project/source_ref 等元字段未被使用却仍随每行读出。真正省 IO 需返回精简结构
/// (如 KnowledgeVectorHit { id, kind, title, content, reuse_count })替换返回类型,
/// 但这会改变 search_vector 签名与 merge_hybrid_results 调用契约——当前保守不动,
/// 待向量检索量级或 reasoning 文本体积成为瓶颈再单独立项。SELECT 列化本身不省字段,
/// 仅消除 SELECT * 的隐式依赖与未知列风险。
pub async fn search_vector(&self, query_vec: &[f32], limit: usize) -> Result<Vec<(KnowledgeRecord, f32)>> {
let conn = self.conn.clone();
let query_vec = query_vec.to_vec();
tokio::task::spawn_blocking(move || {
let guard = conn.blocking_lock();
// 显式列: 14 个 KnowledgeRecord 字段 + embedding(余弦计算用)
const COLS: &str = "id,kind,title,content,tags,status,confidence,reuse_count,verified,\
source_project,source_ref,reasoning,created_at,updated_at,embedding";
let mut stmt = guard
.prepare("SELECT * FROM knowledges WHERE status = 'published' AND embedding IS NOT NULL")
.prepare(&format!(
"SELECT {COLS} FROM knowledges WHERE status = 'published' AND embedding IS NOT NULL"
))
.map_err(|e| Error::Storage(e.to_string()))?;
let rows = stmt
.query_map([], |row| {