From 086c528796ede70ef9598e8472072b006b300e14 Mon Sep 17 00:00:00 2001
From: lxyer <237809796@qq.com>
Date: Wed, 24 Apr 2019 18:09:56 +0800
Subject: [PATCH] 'review'

---
 pom.xml                                           | 14 ++------------
 src/com/eversec/kit/creator/ICreator.java         | 14 --------------
 src/com/eversec/kit/creator/Runner.java           |  4 ++++
 src/com/eversec/kit/creator/impl/page/VueKit.java |  3 +++
 4 files changed, 9 insertions(+), 26 deletions(-)

diff --git a/pom.xml b/pom.xml
index fecb30f..a26ead4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -7,7 +7,7 @@
 
     <groupId>com.eversec.kit</groupId>
     <artifactId>lxy-kit</artifactId>
-    <version>2.0_0228</version>
+    <version>2.0_0424</version>
 
     <dependencies>
         <dependency>
@@ -16,21 +16,11 @@
             <version>1.9.9</version>
         </dependency>
 
-        <dependency>
-            <groupId>org.apache.poi</groupId>
-            <artifactId>poi</artifactId>
-            <version>3.17</version>
-        </dependency>
-        <dependency>
-            <groupId>org.apache.poi</groupId>
-            <artifactId>poi-ooxml</artifactId>
-            <version>3.17</version>
-        </dependency>
         <!-- excel操作支持 -->
         <dependency>
             <groupId>com.lxyer</groupId>
             <artifactId>excel</artifactId>
-            <version>0.1.0</version>
+            <version>0.1.1</version>
         </dependency>
 
         <dependency>
diff --git a/src/com/eversec/kit/creator/ICreator.java b/src/com/eversec/kit/creator/ICreator.java
index 1775e8e..f630b46 100644
--- a/src/com/eversec/kit/creator/ICreator.java
+++ b/src/com/eversec/kit/creator/ICreator.java
@@ -29,21 +29,7 @@ public abstract class ICreator {
     public static String pageModel;
     public static String author;
     private static List<String> sheetNames;
-    /*static {
-        xlsPath = PropKit.getProperty("xlsPath", "res/xls/table.xls");
-        pkg = PropKit.getProperty("pkg", "");
-        tplPath = PropKit.getProperty("tplPath", "");
-        dirPath = PropKit.getProperty("dirPath", "");
-        pageDirPath = PropKit.getProperty("page.dirPath", dirPath);
 
-        pageModel = PropKit.getProperty("page.model", "");
-        author = PropKit.getProperty("author", "lxy-kit");
-        sheetNames = sheets(PropKit.getProperty("sheetNames", ""));
-
-        //路径兼容处理
-        if (!dirPath.endsWith("/")) dirPath += "/";
-        if (!pageDirPath.endsWith("/")) pageDirPath += "/";
-    }*/
     public static void setCfgBean(CfgBean cfgBean) {
         ICreator.cfgBean = cfgBean;
         xlsPath = cfgBean.getXlsPath();
diff --git a/src/com/eversec/kit/creator/Runner.java b/src/com/eversec/kit/creator/Runner.java
index d30c358..d122c59 100644
--- a/src/com/eversec/kit/creator/Runner.java
+++ b/src/com/eversec/kit/creator/Runner.java
@@ -26,6 +26,10 @@ public class Runner {
         List<ICreator> creators = new ArrayList<>();
 
         List<String> ca = cfgBean.getCa();
+
+        // fixme:bfx ,
+        //  此处逻辑比较混乱可改善
+        //  R:lxy
         ca.forEach(x -> {
             if ("service".equalsIgnoreCase(x)) {
                 if ("mb".equalsIgnoreCase(cfgBean.getServiceTpl())){
diff --git a/src/com/eversec/kit/creator/impl/page/VueKit.java b/src/com/eversec/kit/creator/impl/page/VueKit.java
index c46971b..7c5594e 100644
--- a/src/com/eversec/kit/creator/impl/page/VueKit.java
+++ b/src/com/eversec/kit/creator/impl/page/VueKit.java
@@ -30,6 +30,9 @@ public class VueKit extends PageKit {
             x.put("isMust", isMust(x));
             x.put("fieldType", getFiledType(x.get("cate")+""));
             x.put("fieldV",createFiled(x));
+            // Fixme: bfx ,
+            //  下面几个if - else 中存在明显的重复性代码，可改善
+            //  R:lxy
             if ("1".equals(x.get("column"))){
                 sc.add((x.get("field") + "").trim());
             }