lxy/ticket-workbench
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

修复: 代码审查4个必改项+4个建议改进

Browse Source 
- 工单编号改为业务格式 TK-yyMMdd-NNN
- 类型断言加 comma-ok 防 panic
- priority 用指针区分未传/P0
- json.Marshal 错误处理
- 提取 ParseID 公共函数消除重复
- HTTP client 包级别复用
- LIKE 查询特殊字符转义
- interface{} → any
- auth 中间件用 dto.Fail 统一响应
This commit is contained in:
绝尘
2026-05-13 19:01:06 +08:00
parent c5c2a64a48
commit e94f160782
8 changed files with 67 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
backend/internal/handler/analysis_handler.go
View File

@@ -1,8 +1,6 @@
package handler
import (
"strconv"
"github.com/casehub/ticket-workbench/internal/config"
"github.com/casehub/ticket-workbench/internal/dto"
"github.com/casehub/ticket-workbench/internal/middleware"
@@ -14,10 +12,8 @@ import (
func AnalyzeTicket(db *gorm.DB, cfg *config.Config) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -40,10 +36,8 @@ func AnalyzeTicket(db *gorm.DB, cfg *config.Config) gin.HandlerFunc {
func GetAnalysis(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -59,10 +53,8 @@ func GetAnalysis(db *gorm.DB) gin.HandlerFunc {
func ConfirmAnalysis(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
ticketid, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
ticketid, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -84,7 +76,7 @@ func ConfirmAnalysis(db *gorm.DB) gin.HandlerFunc {
return
}
err = service.ConfirmAnalysis(db, analysis.Analysisid, req.Category, req.Priority, req.Summary, user.Userid)
err := service.ConfirmAnalysis(db, analysis.Analysisid, req.Category, req.Priority, req.Summary, user.Userid)
if err != nil {
c.JSON(200, dto.Fail("确认失败"))
return

14
backend/internal/handler/note_handler.go
View File

@@ -1,8 +1,6 @@
package handler
import (
"strconv"
"github.com/casehub/ticket-workbench/internal/dto"
"github.com/casehub/ticket-workbench/internal/middleware"
"github.com/casehub/ticket-workbench/internal/service"
@@ -12,10 +10,8 @@ import (
func ListNotes(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -31,10 +27,8 @@ func ListNotes(db *gorm.DB) gin.HandlerFunc {
func AddNote(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}

30
backend/internal/handler/ticket_handler.go
View File

@@ -1,8 +1,6 @@
package handler
import (
"strconv"
"github.com/casehub/ticket-workbench/internal/dto"
"github.com/casehub/ticket-workbench/internal/middleware"
"github.com/casehub/ticket-workbench/internal/service"
@@ -37,10 +35,8 @@ func ListTickets(db *gorm.DB) gin.HandlerFunc {
func GetTicket(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -80,10 +76,8 @@ func CreateTicket(db *gorm.DB) gin.HandlerFunc {
func UpdateTicket(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -99,7 +93,7 @@ func UpdateTicket(db *gorm.DB) gin.HandlerFunc {
return
}
err = service.UpdateTicket(db, id, req.Title, req.Content, req.Contactname, req.Contactphone, req.Category, req.Priority, req.Handlerid, user.Userid)
err := service.UpdateTicket(db, id, req.Title, req.Content, req.Contactname, req.Contactphone, req.Category, req.Priority, req.Handlerid, user.Userid)
if err != nil {
c.JSON(200, dto.Fail("更新失败"))
return
@@ -111,10 +105,8 @@ func UpdateTicket(db *gorm.DB) gin.HandlerFunc {
func UpdateTicketStatus(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}
@@ -130,7 +122,7 @@ func UpdateTicketStatus(db *gorm.DB) gin.HandlerFunc {
return
}
err = service.UpdateTicketStatus(db, id, req.Status, user.Userid)
err := service.UpdateTicketStatus(db, id, req.Status, user.Userid)
if err != nil {
c.JSON(200, dto.Fail("更新失败"))
return
@@ -142,10 +134,8 @@ func UpdateTicketStatus(db *gorm.DB) gin.HandlerFunc {
func GetOperationLogs(db *gorm.DB) gin.HandlerFunc {
return func(c *gin.Context) {
idStr := c.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
c.JSON(200, dto.Fail("参数错误"))
id, ok := middleware.ParseID(c)
if !ok {
return
}